Skip to content

feat: v0.3.0-alpha feedback#21

Open
ElouenGinat wants to merge 7 commits into
mainfrom
doc
Open

feat: v0.3.0-alpha feedback#21
ElouenGinat wants to merge 7 commits into
mainfrom
doc

Conversation

@ElouenGinat

Copy link
Copy Markdown
Collaborator

No description provided.

@marcboulle marcboulle left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@popescu-v popescu-v left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd state in the commit message that the API comparison markdown file is kept in the repo.

…hist. rework hist implmentation to be identical to matplotlib. rework the demo notebook to be simpler. Add better errors in backend.
@ElouenGinat ElouenGinat linked an issue Jun 26, 2026 that may be closed by this pull request
@ElouenGinat ElouenGinat requested a review from marcboulle June 26, 2026 08:30

@marcboulle marcboulle left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tout cela me semble très bien

Quelques améliorations de détail indiquées en note de review

Pour le derniers points de commit: ne garder qu'un titre court, et mettre en note de commit ce qui a été fait (essentiellement, reprendre le dernier commentaire que tu as ajouté dans l'issue feedback).

Le nouvelle version de la demo me semble très bien, mais c'est difficile de se rendre compte dans l'interface de review de github: j'aurais besoin d'une béta 2 du site pour tout relire une dernière fois (après résolution du problème Sphynx résiduels avec Vladimir).

Comment thread src/khisto/matplotlib/hist.py
Comment thread src/khisto/matplotlib/hist.py Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread test.py Outdated
Comment thread docs/demo.ipynb Outdated
@ElouenGinat ElouenGinat changed the title fix: remove API comparison card in doc index feat: v0.3.0-alpha feedback Jun 26, 2026

@marcboulle marcboulle left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/demo.ipynb
"(count divided by bin width) shows the true shape of the distribution.\n",
"\n",
"> 📚 For a didactic walk-through of optimal histograms — from the simplest to the\n",
"> most complex — see the\n",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mettre sur une seule ligne
most complex — see the histogram documentation in [Khiops fundations](https://khiops.org/learn/understand/)\n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback from alpha-test

3 participants